search

OctopusDeploy / Issues

| Public | Bug reports and known issues for Octopus Deploy and all related tools
https://octopus.com
162 stars 20 forks source link

Nuget Packages Being Re-uploaded If Version Contains '+' #7184

Closed FinnianDempsey closed 1 year ago

FinnianDempsey commented 2 years ago

Team

Severity

Workaround Exists

Version

2021.2.7831

Latest Version

I could reproduce the problem in the latest build

What happened?

Nuget packages only with '+' in the version are not being found in the cache and are being re-uploaded.

Reproduction

Deploy a nuget package to a Tentacle with a version containing '+' e.g. version 1.0.0-alpha.6+test. Subsequent deployments will not find the package in the cache and will re-upload to the Tentacle.

Error and Stacktrace

13:29:44   Verbose  |         Package js-todo version 1.0.0-alpha.6+test hash fd03a9bf476da854c9438490756cd94deeef6f95 has not been uploaded.
13:29:44   Verbose  |         Finding earlier packages that have been uploaded to this Tentacle.
13:29:44   Verbose  |         Found 5 earlier versions of js-todo on this Tentacle
13:29:44   Verbose  |         - 1.0.0-alpha.6+test: C:\Octopus\Local One\Files\js-todo@S1.0.0-alpha.6+test@2D79BE7C22BAFC4B96644BFB4A2D3DFE.zip
13:29:44   Verbose  |         - 1.0.0-alpha.6: C:\Octopus\Local One\Files\js-todo@S1.0.0-alpha.6+test@41B71DBF64205C46B94E1570ED8E0997.nupkg
13:29:44   Verbose  |         - 1.0.0-alpha.6: C:\Octopus\Local One\Files\js-todo@S1.0.0-alpha.6+test@5AF828C71E8A0047B7D934226CBE5F8C.nupkg
13:29:44   Verbose  |         - 1.0.0-alpha.6: C:\Octopus\Local One\Files\js-todo@S1.0.0-alpha.6+test@880A2EC0BBBB214AA2222DC5DA08D94F.nupkg
13:29:44   Verbose  |         - 1.0.0-alpha.6: C:\Octopus\Local One\Files\js-todo@S1.0.0-alpha.6+test@90CC0DC84D05C64E9FAE1868DB49BEFC.nupkg
13:29:44   Verbose  |         Process C:\Windows\system32\WindowsPowershell\v1.0\PowerShell.exe in C:\Octopus\Local One\Work\20211123032942-511-112 exited with code 0
13:29:44   Verbose  |         Exit code: 0
13:29:44   Verbose  |         Found no locally cached versions of js-todo so we can't perform a delta upload, entire package will be uploaded.
13:29:44   Info     |         Uploading package js-todo (69.616 KB)...
13:29:44   Verbose  |         Requesting upload...
13:29:44   Info     |         Beginning streaming transfer of js-todo@S1.0.0-alpha.6+test@2FDF1DBB421A8C4AA1AFE1D16EC0CE7D.nupkg
13:29:44   Info     |         Stream transfer complete

More Information

This only effects nuget packages. Zip packages work as expected.

Workaround

Don't include '+' in the version:

image

Internal Link - Zendesk Internal Link - Slack

FinnianDempsey commented 2 years ago

Likely related to: https://github.com/OctopusDeploy/Issues/issues/6965

droyad commented 2 years ago

Thanks. It looks like this has been around for a while and it's impact is not severe. We've put it onto the future backlog for now.

octoreleasebot commented 1 year ago

Release Note: NuGet packages with build metadata in the version will now use the package cache to speed up transfers

Octobob commented 1 year ago

:tada: The fix for this issue has been released in:

Release stream Release
2023.3 2023.3.1477
2023.4+ all releases