Manual Intervention Step does not stop deployment if aborted when guided failure is enabled.

Clare-Octopus commented 2 years ago

Team

[X] I've assigned a team label to this issue

Severity

Not blocking deployments, assigned team needs to cancel deployment twice to actually cancel it.

Version

2019.x

Latest Version

I could reproduce the problem in the latest build

What happened?

When having guided failure set up for an environment or project and you include a manual intervention step in the project you should be able to abort the release deployment in the manual intervention step which should then cancel the whole deployment.

What is currently happening is when you click on the abort button on the manual intervention step it triggers guided failure and asks if you want to cancel the project. This seems like a bug as a user should not need to confirm twice if the project needs to be cancelled.

The manual intervention step does cancel the deployment with guided failure enabled in older versions of Octopus but a user here has confirmed 2021.2.7727 was working properly and I am currently on 2022.1.2133 which is displaying the guided failure message after an abort in the manual intervention step.

Reproduction

Enable guided failure for a project or environment
Add a manual intervention step to that project or a project scoped to that environment
Create a release and assign the manual intervention step to yourself
Abort the manual intervention step and confirm the abort.
Wait for Octopus to validate the abort and you will see guided failure kick in

After you abort the manual intervention step it should cancel the project not trigger guided failure.

Error and Stacktrace

Task ID:        ServerTasks-2729
Related IDs:    Deployments-607, Channels-161, Releases-406, Projects-161, Spaces-1, Environments-1
Task status:    Executing
Task queued:    Wednesday, 30 March 2022 4:06:05 PM +01:00
Task started:   Wednesday, 30 March 2022 4:06:05 PM +01:00
Task completed: Wednesday, 30 March 2022 4:06:05 PM +01:00
Task duration:  less than a second
Server version: 2022.1.2133
Server node:    OCTOPUS-SERVER

                    | == Running: Deploy RandomQuotes Website release 0.0.23 to Development ==
16:06:05   Verbose  |   Guided failure is enabled for this task
16:06:25   Info     |   Deploy RandomQuotes Website release 0.0.23 to Development
16:06:25   Verbose  |   Guided failure is enabled for this task
16:06:25   Error    |   The user did not complete the manual step
                    | 
                    |   == Success: Step 1: Manual Intervention Required ==
16:06:05   Verbose  |     Manual Intervention Required completed
16:06:25   Verbose  |     Resuming after completion
16:06:25   Info     |     Submitted by: octoadmin@octopus_domain.com at 2022-03-30T15:06:17.0462151+00:00
16:06:25   Verbose  |     Updating manifest with output variables
16:06:25   Verbose  |     Updating manifest with action evaluated variables
                    |   
                    |     == Success: Worker ==
16:06:05   Verbose  |       Octopus Server version: 2022.1.2133
16:06:05   Verbose  |       Environment Information:
                    |       IsRunningInContainer: False
                    |       OperatingSystem: Microsoft Windows 10.0.17763
                    |       OsBitVersion: x64
                    |       Is64BitProcess: True
                    |       CurrentUser: OCTOPUS_DOMAIN\octoadmin
                    |       MachineName: OCTOPUS-SERVER
                    |       ProcessorCount: 8
                    |       CurrentDirectory: C:\Windows\system32
                    |       TempDirectory: C:\Users\octoadmin\AppData\Local\Temp\
                    |       HostProcessName: Octopus.Server
                    |       PID: 7916
16:06:05   Info     |       Pausing the deployment while manual intervention is requested
16:06:05   Verbose  |       Successfully finished Manual Intervention Required on a Worker
                    |     
                    |   == Pending: Acquire packages ==
                    |   
                    |   == Pending: Step 2: Deploy to IIS ==
                    |

More Information

Ticket for the customer that noticed this issue - https://octopus.zendesk.com/agent/tickets/86427 (Internal)

Workaround

None at the moment, the only thing you can do is go into the project release again once the guided failure has been triggered and set it to 'Fail', this will then cancel the deployment.

mstali02 commented 1 year ago

Hello, there is any updated in this case?

michelle-luana commented 1 year ago

Hi @mstali02 This isn't being actively worked on as no other customers appear to be impacted. We will continue to monitor how many customers this issue impacts and reevaluate priority if this changes.

sisyphe999 commented 9 months ago

Hi, I guess I have the same kind of issue. On our deployment process the guided failure is enabled and we have a manual validation step just before the step performing the switch to production. But the manual Abort action doesn't stop the deployment.

michelle-luana commented 9 months ago

Thanks @sisyphe999 we'll make note that this is now impacting more customers!

MitchellCShaw commented 8 months ago

Seconding that our organization is also experiencing this issue!

michelle-luana commented 5 months ago

Thank you @MitchellCShaw. Noted and will revisit the priority on this one.

OctopusDeploy / Issues