TeamCity integration plugin includes -gitRef argument when it should be ignored

[danefalvo]

Team

• [X] I've assigned a team label to this issue

Severity

Some Users inconvenienced - Effective Workaround available

Version

latest

Latest Version

I could reproduce the problem in the latest build

What happened?

The Teamcity integration step "Create Octopus Release" has an optional argument for "Git Ref". The subtext of the Git Ref argument is as follows:

However "Git Ref" is not ignored on non-version controlled projects, leading to an error message with the following:

Since the provided project is not a version controlled project, the --gitCommit and --gitRef arguments are not supported for this command.

Reproduction

Customer has reproduced. https://help.octopus.com/t/teamcity-plugin-create-release-fails-for-non-version-controlled-projects/27897 Will internally reproduce if required.

Error and Stacktrace

No response

More Information

No response

Workaround

No response

[dylanlerch]

The behaviour here is intentional, but the help text is incorrect. We're going to fix up the help text to explain that this field should be left blank for projects that are not in Git.

We're intentionally strict these Git ref and commit values. If it's required, it must be set. If it's going to be ignored, it must be blank. If a value is being passed, we assume you want it to be used.

We're not against changing this in the future at some point, but it's not something we're looking at doing at the moment.

[octoreleasebot]

Release Note: Fix help text for Git ref and Git commit parameters. This now properly explains how they should be set for non-Git projects.