Packages acquired onto multiple workers for the same step

veochen-octopus commented 1 year ago

Severity

Workaround exists

Version

2023.1

Latest Version

I could reproduce the problem in the latest build

What happened?

When the worker lease cap opt-in behaviour is enabled (by setting OCTOPUS__WorkerLeases__LeaseCap to above zero), and certain steps reference multiple packages (including the docker image if using execution containers), the packages for a step can be uploaded onto different workers, causing steps to fail because they're looking for packages that are not all on the current worker.

Reproduction

Set OCTOPUS__WorkerLeases__LeaseCap to a small value, say 2
Create a worker pool of 2 workers
Create several (e.g. 7) identical steps, all refencing the same 2 packages from the built-in feed. This could be either zip or nuget
Deploy a release <- should be able to see some form of error about a missing/unstaged package

These can be run directly on the workers, or using the worker tools image. Slightly different errors may be seen but the underlying behaviour would be the same.

Error and Stacktrace

Could not find package file ...

or

package ... was not found at ...

or

No package has been staged

More Information

No response

Workaround

Set OCTOPUS__WorkerLeases__LeaseCap to 0

octoreleasebot commented 1 year ago

Release Note: Fixed package acquisition with multiple workers and multiple package references when lease cap is enabled

Octobob commented 1 year ago

:tada: The fix for this issue has been released in:

Release stream	Release
2023.1	2023.1.10689
2023.2	2023.2.11881
2023.3	2023.3.1899
2023.4+	all releases

OctopusDeploy / Issues