OctopusDeploy / Issues

| Public | Bug reports and known issues for Octopus Deploy and all related tools
https://octopus.com
161 stars 20 forks source link

Cancelling a deployment queued to a Polling Tentacle that has recently disconnected does not stop RPC retries #8535

Closed nathanwoctopusdeploy closed 10 months ago

nathanwoctopusdeploy commented 11 months ago

Severity

No response

Version

2024.1.5531

Latest Version

I could reproduce the problem in the latest build

What happened?

When a deployment to a polling tentacle that has recently gone offline is cancelled, then RPC retries may continue to execute until the RPC retry time limit is reached.

Reproduction

At this point, RPC retry messages will continue to stream in, even though we have cancelled.

Error and Stacktrace

No response

More Information

What appears to be happening is that the cancellation is happening correctly.

But since it has gotten past get capabilities, and has called 'start script', it doesn't know if the Tentacle actually received the message or not. So now it has to call Cancel on the Tentacle just in case.

But because the Tentacle is offline, the Cancel RPC call never gets through.

Workaround

No response

nathanwoctopusdeploy commented 11 months ago

Server is incorrectly trying to Cancel the Script running on Tentacle in this scenario. We know Tentacle has not started the script, so can cancel quickly cancel without trying to cancel the script on Tentacle

image

Octobob commented 9 months ago

:tada: The fix for this issue has been released in:

Release stream Release
2024.1 2024.1.6784
2024.2+ all releases