Health Checks for Cloud Regions fail

[scme0]

Severity

Switching the feature toggle off fixes the issue

Version

from 2024.3.295

Latest Version

I could reproduce the problem in the latest build

What happened?

A new way of performing health checks was introduced in this PR: https://github.com/OctopusDeploy/OctopusDeploy/pull/24706 which is less permissive than the old health check code. Incidentally the code which kicks off Cloud Targets health checks doesn't filter out Cloud Regions (which never require health checks) so health checks are run on Cloud Regions. The new health checks code doesn't handle this and so the health checks fail.

The new health check code was introduced when switching on the feature toggle: OCTOPUS__FeatureToggles__MachineHealthProvidersFeatureToggle

Reproduction

It's a bit tricky to reproduce because the Cloud Targets health check code only runs once a day. You can hack the code to make it run every minute or so.

Steps are simple:

1. Create a Cloud Region
2. Let the Cloud Targets health check task run
3. Health check for Cloud Region fails

Error and Stacktrace

No response

More Information

Slack: https://octopusdeploy.slack.com/archives/CNHBHV2BX/p1718586883146649 Shortcut: https://app.shortcut.com/octopusdeploy/story/82197

Workaround

You can revert the feature toggle OCTOPUS__FeatureToggles__MachineHealthProvidersFeatureToggle to remove this issue.

[octoreleasebot]

Release Note: Fix issue where health checks on Cloud Regions fail

[Octobob]

:tada: The fix for this issue has been released in:

Release stream	Release
2024.3	2024.3.3987
2024.4+	all releases