The $executionResults object, ExitCode property was being assigned before the WaitForExit() method could which potentially result in a null value. Code has been updated to capture exit code after the process has completed.
Results
Exit code should now be properly recorded.
Before
Exit code property could have been null
After
Exit code should now have a value.
Pre-requisites
[X] Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
[X] Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
[X] Parameter names should not start with $
[X] Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
[X] LastModifiedBy field must be present, and (optionally) updated with the correct author
[ ] If a new Category has been created:
[ ] An image with the name {categoryname}.png must be present under the step-templates/logos folder
[ ] The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it
Background
The
$executionResultsobject,ExitCodeproperty was being assigned before theWaitForExit()method could which potentially result in a null value. Code has been updated to capture exit code after the process has completed.Results
Exit code should now be properly recorded.
Before
Exit code property could have been null
After
Exit code should now have a value.
Pre-requisites
Idshould be a GUID that is not00000000-0000-0000-0000-000000000000Idproperty (updating theIdwill break the Library sync functionality in Octopus).Versionshould be incremented, otherwise the integration with Octopus won't update the step template correctly$LastModifiedByfield must be present, and (optionally) updated with the correct authorCategoryhas been created:{categoryname}.pngmust be present under thestep-templates/logosfolderswitchin thehumanizefunction ingulpfile.babel.jsmust have acasestatement corresponding to it