Improved blank line filtering

[REOScotte]

Background

After switching to using [StringSplitOptions]::RemoveEmptyEntries, I realized it wasn't trimming lines that were blank AFTER Trim() executed. So I switched back to using .Where({$_})

Using RemoveEmptyEntries, if someone entered the below list, Row 1 would be included, row 2 would be excluded because its a blank line, but row 3 would also be included since it contains a space. Row 4 as normal.

Row1

Row2

However, with .Where({$_}), only Row 1 and 2 would be included. 

Results

Before

After

Pre-requisites

• [X] Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
  • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
• [X] Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
• [X] Parameter names should not start with $
• [X] Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
• [X] LastModifiedBy field must be present, and (optionally) updated with the correct author
• [X] If a new Category has been created:
  • [ ] An image with the name {categoryname}.png must be present under the step-templates/logos folder
  • [ ] The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

[twerthi]

Have you considered using [string]::IsNullOrWhitespace? This should capture null, empty strings, and spaces.

[REOScotte]

Not sure where it would makes sense. Do you mean inside the .Where clause? Need the Trim() to get rid of errant spaces around a name regardless.