The template allows for the selection of authentication. The switch statement would alter things based on the authentication selected. In the case of Windows Authentication, the code was adding the username input for some reason and relying on the JDBC connection string to have the necessary components to make windows auth work.
Results
If you selected windows auth and didn't add integratedsecurity=true to the string, it would fail.
Before
Windows auth switch would add username input to command line
After
Windows auth switch no longer adds username input to command line, checks jdbc URL connection string for integratedsecurity=true and adds it if it is not present.
Pre-requisites
[X] Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
[X] Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
[X] Parameter names should not start with $
[X] Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
[X] LastModifiedBy field must be present, and (optionally) updated with the correct author
[X] The best practices documented here have been applied
[ ] If a new Category has been created:
[ ] An image with the name {categoryname}.png must be present under the step-templates/logos folder
[ ] The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it
Fixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line
Background
The template allows for the selection of authentication. The switch statement would alter things based on the authentication selected. In the case of Windows Authentication, the code was adding the username input for some reason and relying on the JDBC connection string to have the necessary components to make windows auth work.
Results
If you selected windows auth and didn't add integratedsecurity=true to the string, it would fail.
Before
Windows auth switch would add username input to command line
After
Windows auth switch no longer adds username input to command line, checks jdbc URL connection string for
integratedsecurity=true
and adds it if it is not present.Pre-requisites
Id
should be a GUID that is not00000000-0000-0000-0000-000000000000
Id
property (updating theId
will break the Library sync functionality in Octopus).Version
should be incremented, otherwise the integration with Octopus won't update the step template correctly$
LastModifiedBy
field must be present, and (optionally) updated with the correct authorCategory
has been created:{categoryname}.png
must be present under thestep-templates/logos
folderswitch
in thehumanize
function ingulpfile.babel.js
must have acase
statement corresponding to itFixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line