search

OctopusDeploy / Library

| Public | A repository of step templates and other community-contributed extensions to Octopus Deploy
Other
170 stars 496 forks source link

Create Azure Manage WebJob #1527

Open sharmaharry opened 1 week ago

sharmaharry commented 1 week ago

Background

The PR is to merge a new template for managing Azure web job

Results

This template uses azure tools rather than octopus inbuilt tools and users do not get an error

CLAassistant commented 1 week ago

CLA assistant check
All committers have signed the CLA.

hnrkndrssn commented 6 days ago

Hi @sharmaharry, thank you for your contribution.

It seems we already have a step template for managing Azure web jobs. The only difference I can see between this template and yours is the type of the step (Octopus.Script vs Octopus.AzurePowerShell) and that you can select an Azure account as part of your template but it's not used as part of the script and the interaction with the Kudu API is still done via username/password specified on the step.

Could you please clarify what the difference between these two steps are, and if there is an issue with the existing step that you are hoping to fix by the addition of this new step?

Thank you, Henrik

sharmaharry commented 6 days ago

Hi @sharmaharry, thank you for your contribution.

It seems we already have a step template for managing Azure web jobs. The only difference I can see between this template and yours is the type of the step (Octopus.Script vs Octopus.AzurePowerShell) and that you can select an Azure account as part of your template but it's not used as part of the script and the interaction with the Kudu API is still done via username/password specified on the step.

Could you please clarify what the difference between these two steps are, and if there is an issue with the existing step that you are hoping to fix by the addition of this new step?

Thank you, Henrik

Hi

This template has a little more update than the other one as this will allow users to select between Azure preinstalled tools or Azure tools bundled with Octopus.

Using an old template we get a warning message for using octopus pre-installed azure tools and further octopus will not be supporting those in future.

sharmaharry commented 3 hours ago

@hnrkndrssn do you need any more input on this before you approve the PR ?