OctopusDeploy / Library

| Public | A repository of step templates and other community-contributed extensions to Octopus Deploy
Other
171 stars 503 forks source link

Updating jenkins step template #1554

Closed twerthi closed 2 months ago

twerthi commented 2 months ago

Background

The Jenkins - Queue Job did not have the option to wait until the job had completed. It had the option to specify a timeout value, but not something that would wait until it reported it was no long building. In addition, I've updated the label and help text of the Fail build (now updated to Fail deployment) as it was confusing as to what the option was for. Evaluating the code showed that the intention was to fail the deployment if a SUCCESS status was not returned. If a timeout occurred, the response was empty. I've also added warning to the code that will state that a timeout occurred before a response was received.

Results

Users did not have the ability to simply wait for the build to complete.

Before

There wasn't an option to wait for a build to complete, only specify a timeout value.

After

Users can not check a box to wait for a build to go until completion.

Pre-requisites

github-actions[bot] commented 2 months ago

Start Hyponome locally

docker pull ghcr.io/hnrkndrssn/hyponome:main
docker run --rm -p 8000:8080 -it ghcr.io/hnrkndrssn/hyponome:main

Review in Hyponome

twerthi commented 2 months ago

Doh! Removed :)