search

OctopusDeploy / OctoTFS

| Public | Octopus extensions for Azure DevOps, TFS, VSTS, and VSO
https://marketplace.visualstudio.com/items?itemName=octopusdeploy.octopus-deploy-build-release-tasks
Other
0 stars 41 forks source link

Overwrite mode in yaml definition does not feel right #233

Closed johnsimons closed 2 years ago

johnsimons commented 2 years ago

image

A few things, the options values are booleans + something else.

The autocomplete in the pipeline builder editor assumes 'true' to be boolean and hence errors, the workaround is to wrap it in quotes. Kapture 2022-03-30 at 09 54 14

It would be nice for that yaml to be something like: OverwriteMode: "Overwrite existing"

slewis74 commented 2 years ago

This is odd, the switches got changed sometime back in 2019 to not be a boolean at all, it's now an OverwriteMode.

johnsimons commented 2 years ago

@slewis74 you are looking at the UI, the yaml uses name from the task.json, see https://github.com/OctopusDeploy/OctoTFS/blob/a438d7771350c3551e6eada4cdfa6fb8919e7644/source/tasks/Push/PushV5/task.json#L55-L66 image

johnsimons commented 2 years ago

I don't think we ever thought about the yaml UX 😢

slewis74 commented 2 years ago

👍 I had seen that, imo that is a bug/oversight and is using the wrong name. It is definitely using the wrong options list.

johnsimons commented 2 years ago

agree, but not easy to fix without breaking it