OctopusDeploy / OctoTFS

| Public | Octopus extensions for Azure DevOps, TFS, VSTS, and VSO
https://marketplace.visualstudio.com/items?itemName=octopusdeploy.octopus-deploy-build-release-tasks
Other
0 stars 41 forks source link

Parameter mismatch in OctopusPackNuGet@6 for nuget authors? #294

Closed mmalvik closed 1 year ago

mmalvik commented 1 year ago

Hi!

I believe there is a mismatch in the task definition and the parameter being read for Nuget authors.

If you use the assistant in Azure Devops to create a "Package Application for Octopus - NuGet" task, it will look like this:

- task: OctopusPackNuGet@6
  inputs:
    PackageId: 'test'
    PackageVersion: '1.2.3'
    NuGetDescription: 'My description'
    NuGetAuthors: 'Author 1'

Error

However if you try to run this step you get the following error:

##[error]"Failed to execute pack. Input required: NuGetAuthor
Error: Input required: NuGetAuthor
    at Object.getInput (/home/vsts/work/_tasks/OctopusPackNuGet_72e7a1b6-19bc-48e6-8d20-a81f201d65a3/6.0.465/node_modules/azure-pipelines-task-lib/task.js:226:15)
    at Zg (/home/vsts/work/_tasks/OctopusPackNuGet_72e7a1b6-19bc-48e6-8d20-a81f201d65a3/6.0.465/index.js:50:17712)
    at Gz (/home/vsts/work/_tasks/OctopusPackNuGet_72e7a1b6-19bc-48e6-8d20-a81f201d65a3/6.0.465/index.js:50:18580)
    at Object.<anonymous> (/home/vsts/work/_tasks/OctopusPackNuGet_72e7a1b6-19bc-48e6-8d20-a81f201d65a3/6.0.465/index.js:50:19079)
    at Module._compile (node:internal/modules/cjs/loader:1126:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1180:10)
    at Module.load (node:internal/modules/cjs/loader:1004:32)
    at Function.Module._load (node:internal/modules/cjs/loader:839:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47

Bug

Is there a mismatch in the task definition using NugetAuthors and the parameter NugetAuthor being read? https://github.com/OctopusDeploy/OctoTFS/blob/367e093b4f40e0648c5e05be89051842cda9441d/source/tasks/PackNuGet/PackNuGetV6/task.json#L74

https://github.com/OctopusDeploy/OctoTFS/blob/367e093b4f40e0648c5e05be89051842cda9441d/source/tasks/PackNuGet/PackNuGetV6/input-parameters.ts#L27