search

OctopusDeploy / Octodiff

| Public | 100% C# implementation of remote delta compression based on the rsync algorithm
Other
24 stars 87 forks source link

Is this extra code? #6

Closed MartinDWhite closed 7 years ago

MartinDWhite commented 9 years ago

Line 52 in SignatureBuilder.cs in WriteMetadata(Stream stream, ISignatureWriter signatureWriter) ... var hash = HashAlgorithm.ComputeHash(stream); ...

This line does not appear to have any effect. hash as passed to WriteMetaData, is not used. Removal of this line does not effect the resulting signature file/delta/patch files or the resulting patched files in my testing. This seems to calculate a value (that takes a very long time on large files) and then throw that value away. What is the purpose of this line?

droyad commented 7 years ago

OctoDiff - Is this extra code? #6

MartinDWhite commented 7 years ago

droyad - That link goes to a page I don't have access to see.

markryd commented 7 years ago

Thanks for letting us know about this @MartinDWhite. Really sorry it has taken us so long to look into it.