Add DHCP publicHostNameConfiguration.

OctopusDeploy / OctopusDSC

| Public | A PowerShell DSC resource for installing Octopus Deploy & Tentacles

Other

1 stars 60 forks source link

Add DHCP publicHostNameConfiguration. #269

Closed timothy-mcroy-cengage closed 3 years ago

timothy-mcroy-cengage commented 3 years ago

This detects an IP address that's on the host based on a CIDR range, passed in as the CidrRange parameter.

Discovering the IP this way allows for deployments to non-domain-joined deployment targets to not require public IP addresses.

I'm unsure on tests at this time, there isn't documentation on how to run the tests.

CLAassistant commented 3 years ago

All committers have signed the CLA.

timothy-mcroy-cengage commented 3 years ago

This commit does not check that the DHCP lease has expired during Test-*.

This is a requirement because a server could be snapshotted and scaled, yet never fix its own tentacle address
I need some feedback from Octopus Devs on where the tentacle URL is stored in the Octopus installation. I can't seem to find where that's stored on disk so I can easily test for it.

timothy-mcroy-cengage commented 3 years ago

I've realized that any scenario in which you want the private IP, the appropriate implementation is to simply register your tentacle as a polling tentacle. None of this is necessary if you use polling tentacles, nor would it be stable due to the number of ways your IP address can change between runs of the DSC configuration.

For that reason, I'm going to close this PR.

andyinaus commented 3 years ago

I've realized that any scenario in which you want the private IP, the appropriate implementation is to simply register your tentacle as a polling tentacle. None of this is necessary if you use polling tentacles, nor would it be stable due to the number of ways your IP address can change between runs of the DSC configuration.

For that reason, I'm going to close this PR.

Yeah, and even if the DSC configuration is always the same, always picking up the first private IP address would fail on the second tentacle registration.