| Public | The secure, lightweight, cross-platform agent for Octopus Server which turns any computer into a worker or deployment target for automated deployments and operations runbooks.
A Chocolatey moderator has pointed out that the same chocolateyinstall.ps1 file is being used for both flavours of tentacle.
chocolateyinstall.ps1 is a script that actually runs on the user's machine. It's not only a helper file for Chocolatey. Therefore it needs to be unique for each package.
Results
This PR removes the installation of self-contained tentacles for now, to mitigate any effect on the existing chocolatey package, which should only install the .NET Framework-dependant tentacle.
A follow up PR is being worked on here, which will split each into its own chocolateyinstall.ps1 file.
Packaging code in build.pack.cs has not been rolled back, as it will still be used to control the new chocolateyinstall.ps1 file in the upcoming PR.
Before
We assume that the current state would result in a user getting both flavours installed on Windows. Since the self-contained version is the second one, it would install the self-contained version over the .NET framework dependant version, when a user tries to install the OctopusDeploy.Tentacle package.
After
A user will get only the .NET framework dependant version installed from the OctopusDeploy.Tentacle package.
How to review this PR
Quality :heavy_check_mark:
Pre-requisites
[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.
Background
A Chocolatey moderator has pointed out that the same chocolateyinstall.ps1 file is being used for both flavours of tentacle.
chocolateyinstall.ps1 is a script that actually runs on the user's machine. It's not only a helper file for Chocolatey. Therefore it needs to be unique for each package.
Results
This PR removes the installation of self-contained tentacles for now, to mitigate any effect on the existing chocolatey package, which should only install the .NET Framework-dependant tentacle.
A follow up PR is being worked on here, which will split each into its own chocolateyinstall.ps1 file.
Packaging code in build.pack.cs has not been rolled back, as it will still be used to control the new chocolateyinstall.ps1 file in the upcoming PR.
Before
We assume that the current state would result in a user getting both flavours installed on Windows. Since the self-contained version is the second one, it would install the self-contained version over the .NET framework dependant version, when a user tries to install the OctopusDeploy.Tentacle package.
After
A user will get only the .NET framework dependant version installed from the OctopusDeploy.Tentacle package.
How to review this PR
Quality :heavy_check_mark:
Pre-requisites