OctopusDeploy / OctopusTentacle

| Public | The secure, lightweight, cross-platform agent for Octopus Server which turns any computer into a worker or deployment target for automated deployments and operations runbooks.
https://octopus.com
Apache License 2.0
11 stars 16 forks source link

Add a encryption control character to the log lines #1048

Closed APErebus closed 2 days ago

APErebus commented 2 days ago

Background

We identified an issue with #1047 where an automated upgrade would fail as the script pod would be created by an non-pod log encryption Tentacle, but then after the upgrade the pod log encryption Tentacle would fail as it expects all pod logs to be encrypted.

Results

We have added a new e to the log lines generated by the bootstrap runner. This control character indicates the line is encrypted. An absence of this control char (or being set to p) indicates that the line is in plaintext and should not be decrypted

This PR also include minor nit changes from the review of #1047

Shortcut story: [sc-98480]

How to review this PR

Quality :heavy_check_mark:

Pre-requisites

APErebus commented 2 days ago

I will be testing this change in https://github.com/OctopusDeploy/helm-charts/pull/343 to verify that it behaves as expected

APErebus commented 2 days ago

I have validated locally that this build of Tentacle supports auto-upgrading via the Helm Chart integration tests