OctopusDeploy / cli

| Public | Next Generation of the Octopus CLI :octopus:
Other
35 stars 10 forks source link

Repository not set up correctly for Go major versioning #350

Open seanamos opened 5 months ago

seanamos commented 5 months ago

Since v2, the repository does not work correctly with the Go SDK as it has not been set up correctly to deal with major versions: https://go.dev/doc/modules/major-version

Command to reproduce

➜ go run github.com/OctopusDeploy/cli/cmd/octopus@latest version
1.7.1

➜ go run github.com/OctopusDeploy/cli/cmd/octopus@v2.2.1 version
go: github.com/OctopusDeploy/cli/cmd/octopus@v2.2.1: github.com/OctopusDeploy/cli@v2.2.1: invalid version: module contains a go.mod file, so module path must match major version ("github.com/OctopusDeploy/cli/v2")

➜ go run github.com/OctopusDeploy/cli/v2/cmd/octopus@v2.2.1 version
go: github.com/OctopusDeploy/cli/v2/cmd/octopus@v2.2.1: github.com/OctopusDeploy/cli@v2.2.1: invalid version: module contains a go.mod file, so module path must match major version ("github.com/OctopusDeploy/cli/v2")

As you can see, whether using go install or go run, there is no way to run a newer version than v1.7.1 as the go module/versioning systems requires v2 in the import paths: github.com/OctopusDeploy/cli/v2