search

OctopusDeploy / cli

| Public | Next Generation of the Octopus CLI :octopus:
Other
35 stars 10 forks source link

feat: handle failures in task wait #393

Closed jameschensmith closed 1 month ago

jameschensmith commented 2 months ago

Summary

Checks for FinishedSuccessfully, and returns an error for non-successful tasks. The error message used comes from the C# implementation ("One or more deployment tasks failed.").

Fixes #390.

Notes

By adding more tests to task wait, the test runtime has increased quite a bit due to time.Sleep(5 * time.Second). I would like some input on this. I could potentially replace it with a mock timer to speed things back up. The overhead of adding more tests to task wait is pretty significant currently 😅

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

jameschensmith commented 1 month ago

@APErebus, if you get a chance, could you possibly look into this? If you have any questions / concerns, I'd love to help address them. Thank you!

APErebus commented 1 month ago

@APErebus, if you get a chance, could you possibly look into this? If you have any questions / concerns, I'd love to help address them. Thank you!

Sure! Will look at it today :)

APErebus commented 1 month ago

Nice 👍

Thanks for the review @domenicsim1