search

OctopusDeploy / cli

| Public | Next Generation of the Octopus CLI :octopus:
Other
35 stars 10 forks source link

One or more deployment tasks failed #421

Closed piyush94 closed 1 month ago

piyush94 commented 1 month ago

The bug

octopus release deploy command says One or more deployment tasks failed. even though there is no error in the task log.

Command to reproduce

octopus --space Default --no-prompt release deploy --project My_Project  --environment Development01 --version $release_version --update-variables --output-format basic

Outcome

Deploy My_Project release 0.0.69 to Development01: Executing
Deploy My_Project release 0.0.69 to Development01: Success
One or more deployment tasks failed.

Versions

cli: 2.10.1

Octopus Server: 2024.3.12735

Links

ukaan01 commented 1 month ago

might be because of this change image

I'd assume that we need to check IsCompleted and only after that FinishedSuccessfully

@jameschensmith FYI ^

jameschensmith commented 1 month ago

Oof. I'll see if I can look into that today. Thanks for the ping, @ukaan01.

jameschensmith commented 1 month ago

Yeah. Looks like FinishedSuccessfully is non-nil when a task is not completed. Missed this. Sorry about that. I'll try to get a PR up shortly.

jameschensmith commented 1 month ago

422 should fix this issue.

piyush94 commented 1 month ago

@jameschensmith Thanks