search

OctopusET / sway-contrib

A collection of user-contributed scripts for sway
MIT License
58 stars 22 forks source link

Disable escape in firefox player #13

Closed smason closed 10 months ago

smason commented 11 months ago

Currently this just watches for Firefox's pop-out media player and "disables" the Escape key when it's active.

This is useful because I use a vi like text editor (Helix) and I have a habit of hitting Esc everywhere. This causes the video player to close which isn't what I want to do (I can always use my real keybinding for closing a window if I really want to close it!).

smason commented 11 months ago

I use PEP-636 style Structural Pattern Matching which means it relies on having at least Python 3.10. Would be easy to relax this if somebody else wanted to run with something older.

OctopusET commented 11 months ago

Thank you for your work Would you squash your commits into one?

smason commented 11 months ago

Would you squash your commits into one?

Should be done, wasn't sure if there was other changes do do first so left it kind of bare.

OctopusET commented 10 months ago

I will check this PR and other your PR on this weekend. Thanks for your PR. I think af1e206 should be squashed to previous commit or split the PR first. First PR for disabling escape in firefox player and second PR for the lint.

And also I'm considering using merge PR with squash. Personally I don't prefer merge commit. This project doesn't have to be strict on commit history, but still I don't want it make it mess. Please share your idea people. I'd like to see how other projects are managing PR like this one.

smason commented 10 months ago

I will check this PR and other your PR on this weekend. Thanks for your PR. I think af1e206 should be squashed to previous commit or split the PR first.

yup, squashing makes sense. have squashed the top two commits

And also I'm considering using merge PR with squash. Personally I don't prefer merge commit. This project doesn't have to be strict on commit history, but still I don't want it make it mess. Please share your idea people. I'd like to see how other projects are managing PR like this one.

The upstream sway contributor guidelines don't say much about when to squash. Just had a look at my goto exemplar of a well run project, trio, and their contributing guidelines but it doesn't say much either. They're both much bigger projects so presume it's not much of a concern even of project's their size.

I personally don't care too much about commit contents (as evidenced by the number of mine) so long as they don't get too big and aren't combining unrelated changes. If this was a much bigger project with hundreds or thousands of contributors then things would be different, but given it's only a few people making relatively infrequent contributions I, personally, wouldn't worry too much about it.