Odianosen25 / Monitor-App

Appdaemon App for Andrew's Monitor Presence Detection System
74 stars 9 forks source link

[REQUEST] Remote nodes configuration + misc #39

Open bemilicus opened 4 years ago

bemilicus commented 4 years ago

Hello, just found this great plugin on HACS and looks very interesting!

Would like to know if these extra feature could be present in future releases. Managing remote HA installations could be further easier i think... ;-)

1) ability to reconfigure a remote-node name. One could start with multiple remote nodes from a single (standard) rpi image, so all remote nodes with the same name (ie 'clean'). Collecting MACs from remote nodes and then mapping each MAC address to a unique node name: MAC xx:xx:xx:xx:xx:xx livingroom (remotenodename1) MAC yy:yy:yy:yy:yy:yy: kitchen (remotenodename2) Then send the new names to the nodes. Does this make sense? (this is related to point 2 below)

2) ability to resolve remote-node by its hostname (see above) instead of IP. Home router's dhcp wont assings every time the same ip and configuring reservations its not always possible on all routers or could be time consuming and error prone...

3) ability to re-configure the type of scan on remote-nodes. Instead to login to each remote-node and reconfigure its scan mode, having a central config to map and send the correct scan mode could be nice: node: livingroom > -tdr -a -b node: kitchen > -tad -a -b Or simply mark one node as primary (so with -tdr -a -b) and each further remote-node as secondary (so with -tad -a -b)

Sorry for asking some features eventually already present! I've just read the docs and can't wait to start experimenting with this plugin!

Keep on the good work! Tks

Odianosen25 commented 4 years ago

Hello @bemilicus,

Thanks for the compliments. Below are my responses to your points, not in the right order though

Regards

bemilicus commented 4 years ago

Thank you @Odianosen25!

nice for point 3. it would also be very usefull the ability to configure on remote nodes some monitor's common parameters such mqtt broker IP address and eventually mqtt's user/password instead of having to switch remote nodes one-by-one to configure the same parameters.

Points 1 and 2 are probably related to your 'location' parameter i think. The two parameters (node-name and location) are in strict correlation. Having these two parameters controlled from only one config file should be the way to go ;-)

Thank you very much! Bye

Odianosen25 commented 4 years ago

In the code, I actually access both as the same thing actually. Though it seems I am referencing them differently, they actually the same.

I assumed when setting up monitor, the same location used in setting up the script is the same as that used to specify node name. If a user uses differently, it will not work properly (I should make note of the in the docs actually).

I cannot really control both from a single location if I understand what you are saying, as it is assumed the user should have monitor all setup correctly.

Regards

bemilicus commented 4 years ago

Hello Odianosen25 i quote-reply to simplify thing and keep them clearer ;-)

In the code, I actually access both as the same thing actually. Though it seems I am referencing them differently, they actually the same.

ok - that's good - got it

I assumed when setting up monitor, the same location used in setting up the script is the same as that used to specify node name. If a user uses differently, it will not work properly (I should make note of the in the docs actually).

ok- also this make sense. I agree to the fact that a remote-node name 'must' correspond to the 'location' parameter and i would always expect this... ;-)

I cannot really control both from a single location if I understand what you are saying, as it is assumed the user should have monitor all setup correctly.

Well what i try to say is probably the same as what you try to reach. Given the main target to have the simpliest setup, and assumed location=node-name, i think that make your plugin capable of changing the remote node names based on your 'central' configuration file would be a great help to all ;-)

Hope to hear you back soon!

Thanks

Regards