Odianosen25 / Monitor-App

Appdaemon App for Andrew's Monitor Presence Detection System
74 stars 9 forks source link

Suggestion: combine some of the sensors to reduce clutter :) #51

Open skynet01 opened 4 years ago

skynet01 commented 4 years ago

I have 4 people and 3 sensors so my set up is not very crazy. I also want to add guests so I will probably have 10 total people.. which you guessed it, results in A LOT of sensors being created in HA. I suggest reducing the number of sensors to just binary sensors and a monitor state sensor. We can then move all the confidence information inside each person's sensor so it's still accessible if someone needs it.

Soo then we will only have the following:

sensor.monitor_state

binary_sensor.alias

Again these are just minor suggestions, love this app!

Odianosen25 commented 4 years ago

This kind of makes sense, I understand, and not sure why I didn't think of it before really. If the binary sensor has attributes that states their confidence levels, that will actually be neater. Could be a serious breaking change for some folks. So what I could do, is to make it optional. It will be verbose as is for now as default, and allow for a setting. I personally will prefer this, since I don't use the confidence levels for anything (like most ppl).

Won't be easy though, thanks

Odianosen25 commented 4 years ago

Ah a serious issue to doing it this way, is that the confidence sensors are required before the binary sensors themselves are created. This might wait a while, really more complicated thinking of it as I am looking via the code.

skynet01 commented 4 years ago

Maybe they can live inside Appdaemon kind of like monitor.xxx sensors live?

Odianosen25 commented 4 years ago

They already living in AD. So if that’s the case, will move to using the AD internal ones for the confidence reading (which I had the idea to do before anyway, but got lazy). Then I will make the verbose on HA disables by default. That works thanks