search

Odinodin / data-frisk-reagent

http://odinodin.no/x/datafrisk/
MIT License
109 stars 9 forks source link

React-with-addons dependency #8

Closed Deraen closed 8 years ago

Deraen commented 8 years ago

Is react-with-addons really necessary? Looks like it is not because it is not :required anywhere.

Currently most users will end up with multiple Reacts (in classpath) because Reagent etc. depend on normal version and readme here doesn't ask user to exclude those. At minimum the readme should state that user has to add exclude normal React.

Even better would be to use normal React, or not depend on React directly and just depend on Reagent.

Odinodin commented 8 years ago

Good point, I'll put it on my TODO list. Also, pull requests are welcome :)