Odonno / modern-gitter-winjs

Windows 10 client of gitter, written in WinJS
https://www.microsoft.com/store/apps/modern-gitter/9wzdncrd2tzj
9 stars 0 forks source link

Hamburger menu should disappear when you click on an option #21

Closed gep13 closed 8 years ago

gep13 commented 8 years ago

Steps to reproduce:

  1. Open the Modern Gitter Application
  2. Click the hamburger menu
  3. Click Rooms

At this point, the hamburger menu that popped out should disappear and show me the chosen selection, i.e. the rooms screen.

Instead, the hamburger menu remains in place, and you have to click to the right of the menu in order to see the rooms, which is not ideal.

This issue was seen on my Nokia Lumia 950 XL, with version 2.2.28 of the application.

Odonno commented 8 years ago

I will check. I think it works like on desktop (when you click outside the splitview, it close the menu). I do not own a W10M at the moment.

gep13 commented 8 years ago

You should be able to use the emulator to do some testing though, right?

Odonno commented 8 years ago

It does not work for me...

gep13 commented 8 years ago

@Odonno said... It does not work for me...

You mean the emulator?

Odonno commented 8 years ago

Yes. It runs correctly but the app does not seem to work. I don't know why.

gep13 commented 8 years ago

@Odonno in version 2.2.53 of the application, this problem seems to have come back again :-(

Odonno commented 8 years ago

Yep, that's normal.

gep13 commented 8 years ago

@Odonno sorry, what do you mean that's normal? I would expect that the hamburger menu should disappear when I click on say "Rooms" but it stays open.

Odonno commented 8 years ago

I mean because of the last version, it does not work. Last version is not stable anymore (if it was before ^^). But, it's clearly a bug. I fix it asap.

gep13 commented 8 years ago

@Odonno ah, I see, makes sense. Would it make sense to re-open this issue, or should I raise a new one?

Odonno commented 8 years ago

Hi @gep13,

I tried some Windows 10 apps lately and I see more clearly the behavior of the SplitView. Indeed, there is still a bug because :

xperiandri commented 8 years ago

Same issue

Odonno commented 8 years ago

It is now fixed in the latest version.