search

Odonno / pomodoro-code

A pomodoro timer inside your Visual Studio Code IDE
https://marketplace.visualstudio.com/items/odonno.pomodoro-code
9 stars 0 forks source link

Does it make sense to have a "pause" option #11

Open gep13 opened 8 years ago

gep13 commented 8 years ago

Right now, when you start the timer, it begins counting down from the configured time, and when you stop, and then press play again, it starts again at the configured time. What if I wanted to simply pause the timer, and then continue from where it was?

Perhaps you want Start, Pause and Reset options?

Just a thought.

Odonno commented 8 years ago

@gep13 Yep, seems to be misconception. I'll update it asap.

gep13 commented 8 years ago

:+1:

Odonno commented 8 years ago

@gep13 Fixed in 0.1.10.

Can you confirm ?

gep13 commented 8 years ago

Not at a computer just now, but will confirm tomorrow.

gep13 commented 8 years ago

Yip, this now works :+1:

Just a couple comments...

You have the text "pause pomodoro" in the tooltip, but you are still using a stop icon. Can the icon be changed to a pause one? Also, what happens if I want to abandon the current pomodoro, and start the timer again? Is it possible to have both the pause and the stop icon (or perhaps a reset icon?).

Odonno commented 8 years ago

VS Code text use octicon icon. (https://code.visualstudio.com/docs/extensionAPI/vscode-api#StatusBarItem.text)

I did not find the pause icon here (https://octicons.github.com/) so I started to use a default square. If you can find it, it will be awesome.

It is clearly possible to have both pause and stop commands visible in status bar.

gep13 commented 8 years ago

Ah I see, yes, a limited set of icons. I would have no idea where to start, but it looks like you can add additional ones.

https://github.com/github/octicons/

Odonno commented 8 years ago

We'll see. I think that could be great.