search

OdooCommunityWidgets / website_multi_image

Odoo Website Multi-Image Module
MIT License
29 stars 34 forks source link

[Question] Do you have a problem if our move the module multi image to OCA/e-commerce? #34

Open moylop260 opened 9 years ago

lukebranch commented 9 years ago

@moylop260 ,

Please feel free to move the project to OCA, I give you my approval. I currently have no time to work on this project at the moment due to commitments on other projects.

Please let me know if you need anything from my end in order to proceed.

I had planned to rewrite the module to replace the multi-image store code with a dependency on Pedro Baeza's product_multi_image module:

https://github.com/pedrobaeza/product-attribute/tree/8.0-product_images

as I think it will handle the multi-image store in a more elegant way.

I had also planned on adding features including:

Image Zoom/Magnify Optional Watermarks based on user groups and allow opacity (similar to Magento) for website frontend

I would be honoured to have the project moved to the OCA. Nhomar approached me about it some time ago, however I had no time to work through getting the code up to scratch for OCA standards.

moylop260 commented 9 years ago

ping @pedrobaeza What do you think?

pedrobaeza commented 9 years ago

The module _product_multiimage is now being refactored by @Yajo. You should wait until it's done to base your module in this one I think.

moylop260 commented 9 years ago

Ok I got it Thank you!

lukebranch commented 9 years ago

@moylop260 @pedrobaeza ,

I've followed @Yajo's repository and will keep an eye on that one for the progress on the multi-image module he's building.

Please let me know if there's anything you need from me in the meantime. You can contact me at:

odoocommunitywidgets (at) gmail.com

yajo commented 9 years ago

Sorry for the delay on that, it's quite advanced but I have some new urgent tasks to work on before.

yajo commented 9 years ago

If anyone wants to fork and continue, feel free to do so!

lukebranch commented 9 years ago

@Yajo ,

Thanks for the update. Do you think the models are pretty much fixed as they will be in the final release for the module?

lukebranch commented 9 years ago

@csrocha ,

As you were involved in the initial development of this project and contributed to the original codebase, do you have any thoughts on this, or any objections to moving this repo over to the OCA?

Just to give you an update, Pedro has been working on a feature rich product multi image module, and Yajo is working on abstracting the multi-image part of the module to allow it to be re-used for any multi-image purpose (not just related to products).

He's working on the following modules at the moment:

https://github.com/Yajo/product-attribute/tree/multi_image/multi_image_base

https://github.com/Yajo/product-attribute/tree/multi_image/product_multi_image (Pedro's original with modifications to work with multi_image_base)

yajo commented 9 years ago

Thanks for the update. Do you think the models are pretty much fixed as they will be in the final release for the module?

Mostly. Still lacking polish, update their README and a test suite. But the errors I experience are now the same that were in @pedrobaeza's branch. Also I was wondering if there is any way to abstract a view too, and make concrete models inherit it.

If you want, I can PR, somebody marks as WIP, and we discuss with code and runbots, that is always easier.

lukebranch commented 9 years ago

@Yajo ,

Thanks for the update. I'll see if I can find some time over the weekend to test it out and give feedback.