Closed ryanc-me closed 8 years ago
@MGinshe ,
Thanks for the PR! I am not maintaining this module much these days due to time constraints, however in that the functionality is still not present in the core in 9.0 i'd suggest that I create a 9.0 branch and you target your PR to that branch.
9.0 branch i'll create in a few minutes. Please send a new PR when you get the chance and i'll review it. Thanks!
Hello! This is my first pull-request, so please forgive any mistakes or oversights on my part.
The proposed changes make the module compatible with Odoo v9, and refactor some of the carousel code. I intend on adding support for an image-magnifier plugin, per variant images/filters, and more config options.
Changes include:
This module should be backwards-compatible with v9, so it might be worth doing some testing, then merging into
master
.Hopefully these changes are up-to-standard. Please contact me if there are any issues, my email address is mginshe@gmail.com
Kind regards, Ryan