OdyseeTeam / chainquery

Chainquery parses and syncs the LBRY blockchain data into structured SQL
https://lbry.tech
MIT License
2.25k stars 42 forks source link

Support new metadata / types #105

Closed tzarebczan closed 5 years ago

tzarebczan commented 5 years ago

Support new metadata added in types: https://github.com/lbryio/types/blob/a6f2fd6d5f382f0012383b9076d650c1f6791ada/v2/proto/claim.proto#L29

Also, the NSFW/Mature field is changing to a tag

kauffj commented 5 years ago

@tiger5226 have you concerned a design (or is chainquery already designed?) so that metadata definitions can propagate fully to SQL without any manual work?

If it is already designed this way, there will likely be work to add generic support for one-to-many properties on a claim (tags in the pending types changes).

tiger5226 commented 5 years ago

That is an interesting idea. It is not designed yet. If new meta data is added, it requires a migration to add the additional columns.

I had never thought of an automatic migration based on a library import. Is this what you meant? Like when we compile we auto generate a sql migration for adding missing columns/relationships dynamically?

tiger5226 commented 5 years ago

solved with 1.8 release