Support normalized name

OdyseeTeam / chainquery

Chainquery parses and syncs the LBRY blockchain data into structured SQL

https://lbry.tech

MIT License

2.25k stars 42 forks source link

Support normalized name #96

Closed tiger5226 closed 5 years ago

tiger5226 commented 5 years ago

[ ] Added normalized_name column to the claim table.
[ ] Adjust the response for getclaimsforname to receive the new normalized_name field from the RPC response.
[ ] Adjust Claimtrie sync logic to set this field.
[ ] We will also need to rethink the claimtrie sync as well. Currently we get claims for what will be the vanity name. So we could be inefficiently syncing the claimtrie for no reason now if two names are normalized to be the same now.

BrannonKing commented 5 years ago

to clarify, you don't actually use getclaimsintrie?

BrannonKing commented 5 years ago

and the getclaimsforname has an error in it; the new normalized_name field isn't actually the normalized name until after the hard-fork hits. I can make a change to that. Let me know what you want. I'm thinking to leave it as name until the fork and then call it normalized_name after the fork. That way you can detect the change by what data is there. (The individual claims will have the name field in them either way.)

tiger5226 commented 5 years ago

to clarify, you don't actually use getclaimsintrie?

Correct. I do not use this RPC call. I use getclaimsforname.

and the getclaimsforname has an error in it; the new normalized_name field isn't actually the normalized name until after the hard-fork hits.

Is this an error or a feature? Either way, I was planning on doing full sync after the fork any way, so I don't think this is a problem for Chainquery as it will get updated either way after the fork.

I can make a change to that.

No I don't think anything is needed here.

tiger5226 commented 5 years ago

solved with 1.7 release