search

OdyseeTeam / odysee-api

API server for Odysee
https://odysee.com
MIT License
228 stars 49 forks source link

make publish.fetchFile retry on failed download #360

Closed quantonganh closed 3 years ago

quantonganh commented 3 years ago

Fix #349

anbsky commented 3 years ago

Thank you for your contribution, @quantonganh. I generally like the simple approach, however, this will not handle read timeouts and disconnects while reading the file, which can be quite large.

Additionally, would it be possible to modify or add a test to cover the retry logic? No need to cover all failure scenarios but it would be nice to make sure it works on any of the common ones.

anbsky commented 3 years ago

Closing this as it's been fixed in another pull request, sorry.