search

OdyseeTeam / odysee-frontend

The code that runs odysee.com
https://odysee.com
MIT License
216 stars 68 forks source link

Make CI go green faster? #1010

Open infinite-persistence opened 2 years ago

infinite-persistence commented 2 years ago

Not fully familiar, but should be able to reduce from 10m to under 5m.

  1. borales/actions-yarn (docker stuff + yarn packages?) = 5m
    • A full yarn from all caches cleared takes only 1m59.964s for me, and I have a slow connection.
    • Fetching from git probably shouldn't take long either.
    • Maybe it's the docker initialization that takes the additional time?
  2. lint = 1m
    • 0m33.478s for me.
  3. build = 4m
    • Full production build takes Done in 97.28s for me.
    • Is it clearing the cache and trying to re-fetch the packages? If it's a continuation from (1) and (2), yarn should just take seconds.
david0178418 commented 2 years ago

Are the electron scripts and dependencies still needed for anything? That was just used for the LBRY desktop app, correct?

postinstall:electron still seems to be part of the standard postinstall script. That and the electon dependency downloads only account for a very small amount of time, but removing them would reduce noise to help find more impactfull savings.

david0178418 commented 2 years ago

Browsing the exisint PRs, it looks like that is being addressed in this one here: https://github.com/OdyseeTeam/odysee-frontend/pull/342