Design Feeback - Githubissues

OdyseeTeam / odysee-frontend

The code that runs odysee.com

https://odysee.com

MIT License

210 stars 66 forks source link

Design Feeback #1389

Closed infinite-persistence closed 2 years ago

infinite-persistence commented 2 years ago

[x] Tag appearance is inconsistent

Sometimes red, sometimes gray, sometimes black.

The original theme's tag appearance was consistent everywhere, and I also like that it uses a the smaller font.

infinite-persistence commented 2 years ago

[x] Contrast is bad in dark-over-dark elements

I have a hard time differentiating these elements. I thought it was my screen, but it's the same thing on other devices, so it must be an accessibility (color-blindness, etc.) thing? I don't have color-blindness, but everything just looks "disabled" to me.

Others had the same issue in Discord https://discord.com/channels/721806979928162404/936318782085935155/946583888606662656

infinite-persistence commented 2 years ago

[x] Better use of opacity to differentiate elements in a block, so we can decipher the structure in a glance. e.g. label vs values, title vs. subtitle, main buttons vs aux.

One random example:

The "reply | fire | slime" line used to be gray, emphasizing that: (1) it's a different element than the comment text (2) lower emphasis than the comment text. So, when I'm skimming, the reply line doesn't distract or require my subconscious attention to read it,

The "1 day ago" is a good example -- differentiates the element better, and also tells you the emphasis.

infinite-persistence commented 2 years ago

[x] Styles that break away from the rest

Example: These look odd:

The other similar pages uses Cards, so they are centered, easier to read, button and subtitles are displayed in a consistent style/color.

toshokanneko commented 2 years ago

Mostly patched. I'll keep this thread open for more issues until the end of the month.

infinite-persistence commented 2 years ago

[x] Paid embed instructions confusing due to overlap

Authenticated + < 1 LBC in wallet + https://odysee.com/@test1:d/Content-FREEdom:0

Can't recall how it used to look like.

infinite-persistence commented 2 years ago

[x] https://github.com/OdyseeTeam/odysee-frontend/issues/1389#issuecomment-1108050827 was closed, but I didn't notice any changes?

toshokanneko commented 2 years ago

The changes are subtile. I've increased the opacity of the font color to the maximum (white/black) to make it more obvious that the element is not disabled. I've also adjusted the hover opacity.

toshokanneko commented 2 years ago

Not really ideal, but no longer overlapping.