Missing UUID - Githubissues

OdyseeTeam / odysee-frontend

The code that runs odysee.com

https://odysee.com

MIT License

214 stars 68 forks source link

Missing UUID #1745

Closed jbn closed 2 years ago

jbn commented 2 years ago

There are a high number of lvv calls being written with a blank uuid (several per second).

I can't find the bug on the clickstream side.
The user agents seem to suggest it spans different browsers (e.g. there were edge, chrome, linux, etc).
Most of the calls remain good
I haven't been able to replicate this in my browser

tzarebczan commented 2 years ago

Seems to happen when you click something from the homepage, and then go back and close the video (i..e nothing was clicked from search).

I also noticed resumed sends don't seem to be working - not sure when that broke. Johnny will confirm if he's still getting some (but some may be from android)

tzarebczan commented 2 years ago

Resumed sends do seem to work, not sure what I was seeing before.

Did notice 2 issues there: 1) we don't have playing time for those 2) if you close under 10 seconds, then you end up with blank recsysid and no uuid either. My guess is that we store the entry before that data is loaded, and then append later on future redux saves as the video is playing.

Johnny is getting UUIDs in the case I'm not (play > back > close pop out player). After digging in more, it looks to be timing related. If you stay on a playing video for more than ~10 seconds, the UUID is cleared out - doesn't matter if you click back or click a related video, it won't send.

infinite-persistence commented 2 years ago

Pushed the fix. Re-open if there are still issues.
Re-filing the totalPlayTime issue.

tzarebczan commented 2 years ago

@jbn are you okay with embeds not sending UUID or how do you want to handle that?

jbn commented 2 years ago

uuids are used for two things. for embeds, the only one that is relevant is deduplification. if i understand the front-end code in the embed case, they can't really fire twice, correct? if that's definitely true, i can just look at the embed flag in the lvv post and create a new uuid if its true and the uuid is missing.