search

OdyseeTeam / odysee-frontend

The code that runs odysee.com
https://odysee.com
MIT License
213 stars 68 forks source link

Sorting list can wipe items from it, if all items haven't yet been resolved #2758

Open keikari opened 1 year ago

keikari commented 1 year ago

User reported that items disappear from their list when sorting list to "Oldest first".

Guessing this is what happens:

  1. Have lot of items in list (so items will be resolved in multiple calls)
  2. Have slow internet (resolves take longer to return, at least seem to be easier to repro issue with this)
  3. Go to Edit mode and do some change before all resolves return. (Will create an unsavedChanges version with items that list had so far)
  4. And saving will update the list with that version.

Was able to repro with throttling connection to 2G.

tzarebczan commented 1 year ago

Thanks for looking into that and the detailed repro, sounds about right!

tzarebczan commented 1 year ago

Maybe a quicker solution would be to show a spinner / not allow edit until all are resolved.