search

OdyseeTeam / odysee-frontend

The code that runs odysee.com
https://odysee.com
MIT License
209 stars 65 forks source link

Fix `selectIsCollectionPrivateForId` #3086

Closed keikari closed 4 months ago

keikari commented 4 months ago

Private list with unpublished edits wasn't actually considered private. So if editing in publishing form, would cause submit to try to do collectionUpdate.

Fix: Copied the related stuff from selectHasPrivateCollectionForId to selectIsCollectionPrivateForId, just left out the checks for private versions of published lists. 2024-04-17_18-08

Didn't test much, but don't really see how this could cause any surprises. (Unpublished collections only has the actually private lists)

keikari commented 4 months ago

Didn't got any lint issues locally, seems to be related to previous PR

tzarebczan commented 4 months ago

@toshokanneko worth fixing that lint issue or I should just push it through?

toshokanneko commented 4 months ago

I fixed it in the master branch. @keikari You can update this and and merge it.

keikari commented 4 months ago

Updated, I think. I don't have permission to merge, so will need help with that part too : D