Fix `extras/` dependency problem

infinite-persistence commented 2 years ago

Problem

In the past, I've encountered an issue where a selector defined in extras/lbryinc couldn't be found, even though the code looks ok. Jessop's guess is that there is a circular-dependency somewhere. I managed to skipped the problem back then by moving the selector into another file.
While doing FYP, I found 2 issues: (1) can't import extras/recsys in certain files (2) a very subtle bug that wasn't visible until you visit a page (see "Reproduce" below)

https://github.com/lbryio/lbry-desktop/commit/9f58c529bc35a8799250d6398491effc76549d23 In this commit, we are just importing an action from another file. It looks normal and even compiles, but if you enter a File Page, it crashes because one distant (and unrelated) selector became undefined.

If someone can take a look at it (most likely webpack-related?) to find the root-cause, that will be great to avoid subtle bugs in the future.
Alternatively, I spoke to Jessop and there is no actual need for an "extras/" folder for Odysee ... having to 2 sets of redux code, for example, is confusing at times. I think we can just consolidate it further and move it into ui/, and the import issues should go away.

infinite-persistence commented 2 years ago

If someone can look at the problem under "Reproduce" and understand/fix the problem, that will be great.

infinite-persistence commented 2 years ago

Probably need this https://github.com/aackerman/circular-dependency-plugin

infinite-persistence commented 1 year ago

ui/analytics.js imports lbryinc, which imports ui/analytics.js and its own selectors.

Repro: use analytics.log in selectors/blocklist