search

OdyseeTeam / odysee-ios

The Odysee iOS app with wallet functionality.
MIT License
67 stars 22 forks source link

Get test suite fully passing by fixing failing `MultistreamTests.testBasic` assertion #244

Closed tsheaff closed 2 years ago

tsheaff commented 2 years ago

Results from test suite on master:

Screen Shot 2021-09-22 at 9 11 29 PM

Results on this branch after the fix:

Screen Shot 2021-09-22 at 9 09 39 PM

tzarebczan commented 2 years ago

Thanks Tyler! We'll get a review on this soon.

Sent you a welcome message on https://github.com/lbryio/odysee-ios/pull/245#issuecomment-925883775, same would apply to other PRs.

tsheaff commented 2 years ago

@tzarebczan @akinwale once this merges and test suite is passing, it would be nice to avoid any merges going forward that don't pass the test suite. Thoughts on how to configure this step? We could use CircleCI, Travis etc. I see y'all are using Travis for CI on some of the other repos but not this one. Thoughts?

akinwale commented 2 years ago

@tsheaff I'm not very familiar with CI options for macOS / iOS builds, so I cannot comment on this at the moment. I'll do some research and try to provide feedback later on.