Closed ktprograms closed 2 years ago
Changes made in latest push:
livestreamsCollectionView
as claimListView.tableHeaderView
such that it scrolls along with the claim list. Create the livestreams view programatically to avoid having to create a XIB.Diff link: https://github.com/ktprograms/odysee-ios/compare/1a8fc24..0a9a818
Video demonstration:
Changes made in latest push:
orderBy
parameter in claim search call, since I can't find what the "correct"/equal to website sort order is.infos
from Odysee Livestream API call, since the fetch is small enough that it's probably worth it compared to missing new data. I'm open to opinions to change this, though."Livestreams"
title label and stack view.infos
from Odysee Livestream API call is empty, and if so hide the livestreamsCollectionView
and change the title label to "No livestreams to display at this time. Please try again later."
.Diff link: https://github.com/ktprograms/odysee-ios/compare/0a9a818..9f74309
this is awesome!
1) would it be hard to add to the other categories if a channel in that category has an active livestream?
2) I'll open a separate issue, but we'd probably want to combine this change with our new content v2 api. v2 has a list of not channel ids that should be sent along with the claim searches for wild west, to help filter things down. preview here: https://odysee.com/$/api/content/v2/get
I think both of these would be achievable at the same time, by using channel_ids
or not_channel_ids
, but that should probably be in a separate pull request to keep this one simple.
@tzarebczan The codebase already has a ContentSources file that uses the v1 endpoint, is that okay or is using the v2 endpoint necessary?
For now this is fine, but wanna move to v2 shortly after.
@ktprograms Please fix the conflicts so that I can merge. Thanks.
Still to do:All Done: