OdyseeTeam / odysee-ios

The Odysee iOS app with wallet functionality.
MIT License
69 stars 21 forks source link

Show livestreams in Wild West #287

Closed ktprograms closed 2 years ago

ktprograms commented 2 years ago

Still to do: All Done:

ktprograms commented 2 years ago

Changes made in latest push:

Diff link: https://github.com/ktprograms/odysee-ios/compare/1a8fc24..0a9a818

Video demonstration:

https://user-images.githubusercontent.com/71804605/165898013-17d23776-019b-4b8d-a5b9-32976120ccda.mp4

ktprograms commented 2 years ago

Changes made in latest push:

Diff link: https://github.com/ktprograms/odysee-ios/compare/0a9a818..9f74309

tzarebczan commented 2 years ago

this is awesome!

1) would it be hard to add to the other categories if a channel in that category has an active livestream?

2) I'll open a separate issue, but we'd probably want to combine this change with our new content v2 api. v2 has a list of not channel ids that should be sent along with the claim searches for wild west, to help filter things down. preview here: https://odysee.com/$/api/content/v2/get

ktprograms commented 2 years ago

I think both of these would be achievable at the same time, by using channel_ids or not_channel_ids, but that should probably be in a separate pull request to keep this one simple.

ktprograms commented 2 years ago

@tzarebczan The codebase already has a ContentSources file that uses the v1 endpoint, is that okay or is using the v2 endpoint necessary?

tzarebczan commented 2 years ago

For now this is fine, but wanna move to v2 shortly after.

akinwale commented 2 years ago

@ktprograms Please fix the conflicts so that I can merge. Thanks.