search

OdyseeTeam / odysee-ios

The Odysee iOS app with wallet functionality.
MIT License
67 stars 22 forks source link

Add player rate and jump 10 secs forward/back buttons #312

Closed ktprograms closed 2 years ago

ktprograms commented 2 years ago

Add control views and subclass AVPlayerViewController to intercept touches and replicate hiding/showing behaviour of built-in controls.

Use pull-down menu for player rate on >=iOS 14, use picker alert for older iOS versions.

Fix: #276 (Does not show total change) Fix: #18 (Maybe use suggested libraries in future?)

ktprograms commented 2 years ago

Just tested, controls are still shown when viewing text content.

Will fix next week.

ktprograms commented 2 years ago

Diff 8ccc871...70a576f Hide player control views, only unhide when initializing avpc

ktprograms commented 2 years ago

Diff 70a576f...6b8abd1 Move speed button configuration to viewDidLoad

tzarebczan commented 2 years ago

Keith will take another shot at using another library.

ktprograms commented 2 years ago

@tzarebczan I took a look at the libraries suggested in #18, but the first two seem unmaintained, and the third doesn't have any UI controls.

Can you try running this and see if the sync between the custom controls and built in controls seems good enough?

Alternatively, the controls could be placed outside the player?

tzarebczan commented 2 years ago

@akinwale can you get this merged and into testflight? Probably better than nothing...