commenting issues on channel page

OdyseeTeam / odysee-ios

The Odysee iOS app with wallet functionality.

MIT License

69 stars 21 forks source link

commenting issues on channel page #336

Closed tzarebczan closed 2 years ago

tzarebczan commented 2 years ago

From KP:

[ ] I can't seem to change the channel to comment in a Channel Page's discussion section.
[ ] Also, it crashes when I tap on my name in that page.

He thinks it may be something with his account, so need to repro first.

ktprograms commented 2 years ago

What do you mean by "can't change the channel to comment"?

The crash is because the sourceView for the popover isn't set, I can fix that.

infinite-persistence commented 2 years ago

What do you mean by "can't change the channel to comment"?

The "Comment as @xxx" should be a dropdown for users to select the channel to comment as, but it seems like just a text.

ktprograms commented 2 years ago

Ah, I see. Would making it link/button coloured be okay?

tzarebczan commented 2 years ago

It should look the same as commenting on other pages (I don't recall if we do a drop down there?)

ktprograms commented 2 years ago

The UI is the same for all the comment areas as it uses the same view controller.

On Fri Jul 1, 2022 at 10:07 PM +08, Thomas Zarebczan wrote:

It should look the same as commenting on other pages (I don't recall if we do a drop down there?)

-- Reply to this email directly or view it on GitHub: https://github.com/OdyseeTeam/odysee-ios/issues/336#issuecomment-1172388095 You are receiving this because you commented.

Message ID: @.***>

infinite-persistence commented 2 years ago

Yeah, I'm not seeing it selectable in any place.

Ah, I see. Would making it link/button coloured be okay?

Should be fine, as long as consistent everywhere like Tom mentioned.