Not automatically going to PiP after restoring PiP

OdyseeTeam / odysee-ios

The Odysee iOS app with wallet functionality.

MIT License

67 stars 22 forks source link

Not automatically going to PiP after restoring PiP #375

Open ktprograms opened 1 year ago

ktprograms commented 1 year ago

Steps to reproduce:

Open Video
Swipe to home to automatically show PiP
Press PiP expand button
Swipe to home again

PiP does not appear now, and playback stops.

This functionality was broken in https://github.com/OdyseeTeam/odysee-ios/commit/329324e81c96e423be0864ee9c06c2360b61a456.

@akinwale I've looked at this, and I'm pretty sure it's because this block isn't getting called in the short init path here, but when I add that block to the short init path it still doesn't work.

anohren commented 1 year ago

I managed to (somehow) open PiP once after updating to latest, but since then I've been unable to enter PiP even when opening a video and pressing the home button, after a fresh launch.

Maybe the same issue.

Does your described problem persist between launches @ktprograms?

ktprograms commented 1 year ago

Does your described problem persist between launches

No.

Previously it should reset when opening another video but I think it's currently broken with the "No autoplay if already playing" stuff.