search

OdyseeTeam / player-server

Media server for Odysee
28 stars 12 forks source link

Merge with reflector #26

Closed lyoshenka closed 3 years ago

lyoshenka commented 3 years ago

this is still missing the command that starts reflector itself

lyoshenka commented 3 years ago

@andybeletsky i rearranged a lot of stuff, if you're curious

anbsky commented 3 years ago

As a suggestion, I think it would increase the review-ability of pull requests greatly if large code reorgs (like deleting/creating large source code files or merging external packages) are done separately from small refactoring.

lyoshenka commented 3 years ago

As a suggestion, I think it would increase the review-ability of pull requests greatly if large code reorgs (like deleting/creating large source code files or merging external packages) are done separately from small refactoring.

I did put them in separate commits, but you're right that its still hard to read on github. I'll try to rebase those down the commit stack and merge them into master on their own. Sometimes its hard though.

lyoshenka commented 3 years ago

merged in 4197ca4cfc828de088ff3f43d5c918eff76bd99b