search

OdysseasKr / online-nilm

Code for the experiments in "Sliding Window Approach for Online Energy Disaggregation Using Artificial Neural Networks"
60 stars 16 forks source link

ignore the last window size? #5

Open Hessen525 opened 4 years ago

Hessen525 commented 4 years ago

Hi, @OdysseasKr Thanks for your work. gen_batch(chunk.iloc[:,1], chunk.iloc[:,0], chunk.shape[0]-window_size, 0, window_size) in gen.py. Why not chunk.shape[0]-window_size+1?

ex: batch size: 5, window_size = 2, the number of sliding windows should be 5-2+1=4 if I understand correctly,

Thanks.

OdysseasKr commented 4 years ago

You are indeed correct on that, I will fix that as soon as possible.