search

Oefenweb / ansible-fail2ban

Ansible role to set up fail2ban in Debian-like systems
MIT License
117 stars 55 forks source link

Added filter for WordPress logins on Apache #7

Closed mvdriel closed 9 years ago

tersmitten commented 9 years ago

Great addition, but wouldn't it be more flexible when copy.src (copy filters task) is configurable (through the optional variable fail2ban_filterd_path). That way there's no need to include all the filters in this role.

@mvdriel What do you think?

mvdriel commented 9 years ago

@tersmitten Good idea. I will update the pull request.

mvdriel commented 9 years ago

@tersmitten What do you think of this update?

tersmitten commented 9 years ago

@mvdriel Does copy work when there are conflicting files in the destination?

mvdriel commented 9 years ago

@tersmitten It will overwrite conflicting files (default behaviour of copy).

tersmitten commented 9 years ago

@mvdriel Do you see any use for specifying multiple directories?

mvdriel commented 9 years ago

@tersmitten Yes, for example when you want to use the filters inside this role and some of your own.

tersmitten commented 9 years ago

@mvdriel Ok, but I rather not have any filters inside this role :-)

tersmitten commented 9 years ago

@mvdriel I'd rather store that in another repository (or folder in an existing one)