search

Oefenweb / ansible-r

Ansible role to set up (the latest version of) R in Ubuntu systems
MIT License
42 stars 27 forks source link

Install GitHub #17

Closed brooklynbagel closed 6 years ago

brooklynbagel commented 6 years ago

Proposed extension to allow packages whose code is hosted on GitHub to be installed through the playbook. My attempt at the proposed enhancement #16

Caveat: I tested the PR locally using your included Vagrantfile and everything checks out on 14.04 and 16.04. However 12.04 seems to have some issues with downloading the packages using remotes::install_github.

tersmitten commented 6 years ago

Can you have a look at the failing tests?

brooklynbagel commented 6 years ago

Sure. Looking at the logs it appears that the installation of the Github package is completing properly but they are failing the idempotence test. I'll have to investigate further.

tersmitten commented 6 years ago

Fixed in #18