Oefenweb / ansible-r

Ansible role to set up (the latest version of) R in Ubuntu systems
MIT License
42 stars 27 forks source link

Allow a speedup by getting the list of packages only once #51

Closed lecorguille closed 3 years ago

lecorguille commented 3 years ago

As you can observe here, we have a LOT of packages.

And since the default behaviour of the role is to fetch the package list at each R library, it take ages.

This PR will provide a switch to only get the list once.

lecorguille commented 3 years ago

https://github.com/Oefenweb/ansible-r/pull/51/checks?check_run_id=1961637784#step:5:8

  ansible-lint
  shell: /bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.9.1/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.1/x64/lib
A valid role namespace is required, edit meta/main.yml and assure that
author field is also a valid namespace:

galaxy_info:
  author: your_galaxy_namespace

See: https://galaxy.ansible.com/docs/contributing/namespaces.html#galaxy-namespace-limitations

We hit this issue: https://github.com/ansible-community/ansible-lint/issues/1400 Which is fixed but not released yet: https://github.com/ansible-community/ansible-lint/pull/1401

lecorguille commented 3 years ago

The new version of ansible-lint still make the test fail.

https://github.com/ansible-community/ansible-lint/blob/master/src/ansiblelint/_prerun.py#L169

The role name must contain 2 letters