search

Oefenweb / ansible-r

Ansible role to set up (the latest version of) R in Ubuntu systems
MIT License
42 stars 27 forks source link

add a default var to set R script path for install #52

Closed FanchTheSystem closed 3 years ago

FanchTheSystem commented 3 years ago

Ansible lint for Github CI fixed here: https://github.com/Oefenweb/ansible-r/pull/53

FanchTheSystem commented 3 years ago

all checks have passed, @tersmitten please review ;)

tersmitten commented 3 years ago

What's the use case of this change? Does /usr/local/bin not suit your needs?

FanchTheSystem commented 3 years ago

What's the use case of this change? Does /usr/local/bin not suit your needs?

Yes in some of our server we use an account which is not root to install R package. This user does not have write access to /usr/local.

We are already able to change the path for R package installation with the variable r_packages_lib. So this variable is needed to also move the R script path.

FanchTheSystem commented 3 years ago

For example installing R package from github as root may be a serious security issue.

FanchTheSystem commented 3 years ago

Please note that there are no impact if you keep running this role as root, and it will give us an easy way to run it as another user

FanchTheSystem commented 3 years ago

@tersmitten , if every thing look goog for you now, maybe we could merge now (and tag a new version)

I am sorry to notify you, but I need those change for some of my server.

tersmitten commented 3 years ago

I'll try to have a look upcoming week

FanchTheSystem commented 3 years ago

thank you