Ofaloaf / postapoc

After the End is a post-apocalypse total conversion mod for Crusader Kings II
117 stars 88 forks source link

Add the IWW and Trollcrafters societies #117

Closed BFKelleher closed 2 years ago

BFKelleher commented 7 years ago

This fork adds the IWW and the Trollcrafters societies. I was a bit lazy, but the customizable localisation files and the scripted effects and triggers can be merged.

BFKelleher commented 7 years ago

Oh, I should add that what I've added here is up to date for 2.7.1.

SteelyGlint commented 7 years ago

I appreciate your hard work and the time you spent creating this, but I'm not currently in favor of adding it to the main branch. I'm just speaking for myself here, maybe the other devs will feel otherwise.

Here are my reasons.

First, I don't like the vanilla satanic societies in general and would therefore not be interested in shouldering the maintenance burden of this addition.

Second, some of the terminology is too modern: we try to add a medieval/apocalyptic twist to things we add, to reflect the centuries of change. Unions only make sense in the context of industrialized or modern work, which doesn't exist in a feudal society.

Third (though somewhat related to the previous reason), I don't see a union as analogous to a satanic society that burns people alive in bronze bulls.

Fourth, I was foolishly hoping that Paradox would overhaul their society events to make proper use of the secret_religion character attributes rather than the trait hacks they originally released with 2.7. At this point I'm assuming it will never happen, but I don't want to merge thousands of lines of changes in case they do this.

BFKelleher commented 7 years ago

I believe the secret religious societies work in vanilla CK2 2.7.1, but in AtE you'd have to write the triggers for the true religions. I got started a bit there for my society, but the rest of the work would need to be finished.