Off-World-Live / obs-spout2-plugin

A Plugin for OBS Studio to enable Spout2 (https://github.com/leadedge/Spout2) input / output
https://knowledge.offworld.live/en/spout-plugin-for-obs-studio
GNU General Public License v2.0
523 stars 49 forks source link

Removing Spout filter crashes OBS Studio #41

Closed Xaymar closed 1 year ago

Xaymar commented 2 years ago

Describe the bug A crash is observed when a Spout filter is added to any video source and removed from it. This crash happens without any Spout clients connected.

To Reproduce

  1. Add any video source.
  2. Add a spout filter to the source.
  3. Remove the spout filter from the source.
  4. Crash.

Expected behavior No crash.

2022-04-12 09-32-08.txt Crash 2022-04-12 09-46-45.txt

Screenshots

About the Software:

About Your Machine :

Additional context Add any other context about the problem here.

campbellwmorgan commented 2 years ago

@Xaymar thanks for this report. Looks similar to #40

Xaymar commented 2 years ago

@campbellwmorgan Looking at the crash logs in #40, this appears to be a different crash. Unfortunately I have not spent any time debugging the plugin to say for sure if it is the same or a different one.

campbellwmorgan commented 1 year ago

@Xaymar could you try https://github.com/Off-World-Live/obs-spout2-plugin/releases/tag/v1.6-beta to see if it resolves your crash issue

Xaymar commented 1 year ago

Currently can't test due to OBS Studio 28.0.x being incredibly unstable even without any plugins installed. I've downgraded to 27.2.4 again, which was the last known stable version of OBS Studio for my system.

flaeri commented 1 year ago

I had a very similar (identical?) crash (spoutCrash.txt), with the same repro steps.

Using the new beta you suggested I can no longer get it to crash by deleting the spout filters. This was on OBS 28.0.3.

campbellwmorgan commented 1 year ago

@Xaymar Could you check to see if this latest release fixes this crash for you https://github.com/Off-World-Live/obs-spout2-plugin/releases/tag/v1.8

Xaymar commented 1 year ago

@campbellwmorgan That version does not appear to load in any OBS Studio version I have.

06:06:18.045: LoadLibrary failed for '../../obs-plugins/64bit/win-spout.dll': The specified module could not be found.
06:06:18.045:  (126)
06:06:18.046: Module '../../obs-plugins/64bit/win-spout.dll' not loaded
Xaymar commented 1 year ago

I've built the plugin from source at the specified version, and it appears to fix the issue.